Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle build strategy #2 automatically in cmake #65

Merged
merged 7 commits into from
May 24, 2017

Conversation

shadowwalkersb
Copy link
Member

This aims to simplify the process of installing from source. The install destination is within a conda environment. That could be the default root environment or any environment that is added and activated by the user. It is possible to enable/disable this behavior by setting/unsetting ENABLE_CONDA cmake variable. It is ON by default.

@sludtke42
Copy link
Member

How does it detect where the conda environment is?

@shadowwalkersb
Copy link
Member Author

How does it detect where the conda environment is?

Seraches for conda in directories listed in PATH. conda will be in $CONDA_PREFIX/bin. So, the conda environment is the parent directory.

find_path(CONDA_PREFIX conda
                PATHS ENV PATH
               )
get_filename_component(CONDA_PREFIX ${CONDA_PREFIX}/.. ABSOLUTE)

@sludtke42
Copy link
Member

sludtke42 commented May 15, 2017 via email

@shadowwalkersb
Copy link
Member Author

shadowwalkersb commented May 15, 2017

The dependencies need to be installed with conda anyways. So, conda will have to be in PATH before getting to cmake step. Instructions are worked on here, http://blake.bcm.edu/emanwiki/EMAN2/COMPILE_EMAN2_ANACONDA.

@shadowwalkersb
Copy link
Member Author

So if you have conda in your path such that 'python' is the conda python, it will find and use it?

Once a conda environment is found, it should find all the dependencies, not only python, within that environment.

@shadowwalkersb shadowwalkersb force-pushed the build-strategy-2 branch 2 times, most recently from f612b8a to e14c4ae Compare May 15, 2017 21:10
@shadowwalkersb shadowwalkersb changed the base branch from master to release/2.21 May 23, 2017 05:05
@shadowwalkersb
Copy link
Member Author

Should we include this in the release?

Copy link
Member

@sludtke42 sludtke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, go ahead, but after you merge, we should do some testing. Are the instructions for using this mechanism for a source compile ready?

@shadowwalkersb
Copy link
Member Author

Instructions are here, http://blake.bcm.edu/emanwiki/EMAN2/COMPILE_EMAN2_ANACONDA.

@shadowwalkersb shadowwalkersb merged commit 2ccd111 into release/2.21 May 24, 2017
@ghost
Copy link

ghost commented May 24, 2017 via email

@shadowwalkersb shadowwalkersb deleted the build-strategy-2 branch May 24, 2017 23:00
@shadowwalkersb shadowwalkersb restored the build-strategy-2 branch June 1, 2017 13:51
shadowwalkersb added a commit that referenced this pull request Jun 1, 2017
Handle build strategy #2 automatically in cmake
@shadowwalkersb shadowwalkersb deleted the build-strategy-2 branch June 5, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants