fix(dashboard): use fixed text color for stat panels #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Looks good. I wonder if there is a way to override settings like this via the embedded panel query parameters or some other dynamic mechanism, though. |
|
Been trying to find a way but seems like everything must be configured via the JSON model. I think the user can change the styling via panel editor if they are authenticated (maybe admin?). Maybe we can figure a way to embed/anchor to the editor view and somehow allow saving latest json model on top of the shipped base JSON? |
|
That's a lot more work than I think is worth doing, honestly. I think this is good to go as it is. |
andrewazores
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cryostatio/cryostat-web#856
This includes fix to panel text to specify single text color with text variant.
Dark Theme
Light Theme