fix(rules): rule archiving and re-activation bugfixes #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
Workflow started at 6/13/2024, 11:06:57 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ (JDK17) |
|
/build_test |
|
Workflow started at 6/13/2024, 11:20:08 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
|
/build_test |
|
Workflow started at 6/13/2024, 2:57:40 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
|
@Mergifyio backport cryostat-v3.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* fix(rules): rule archiving and re-activation bugfixes * refactor * blocking * activate concurrently * cancel job when target disappears * fixup! cancel job when target disappears * apply existing rules to newly appearing targets (cherry picked from commit 233df2a)
andrewazores
added a commit
that referenced
this pull request
Jun 13, 2024
…#519) fix(rules): rule archiving and re-activation bugfixes (#518) * fix(rules): rule archiving and re-activation bugfixes * refactor * blocking * activate concurrently * cancel job when target disappears * fixup! cancel job when target disappears * apply existing rules to newly appearing targets (cherry picked from commit 233df2a) Co-authored-by: Andrew Azores <me@andrewazor.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #517
Description of the change:
Fixes up some issues that arose due to previous refactorings, where collections were improperly modified during traversal, or methods went from blocking operations to returning
Unis which went ignored, or active recordings were improperly left running, or duplicate target definitions were not de-duplicated by JVM ID and thus were acted on multiple times.How to manually test:
./smoketest.bash -Otcleanoption checked and ensure recordings are stopped{ "id": 1, "name": "test", "description": "", "matchExpression": "target.connectUrl.startsWith('service') && target.jvmId != null", "eventSpecifier": "template=Continuous,type=TARGET", "archivalPeriodSeconds": 20, "initialDelaySeconds": 0, "preservedArchives": 2, "maxAgeSeconds": 0, "maxSizeBytes": 26214400, "enabled": true }