-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(id-filter): allow JSON 'id' key on particular endpoints only #337
Conversation
/build_test |
Workflow started at 3/20/2024, 4:21:37 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: At least one test failed ❌ (JDK17) |
/build_test |
Workflow started at 3/20/2024, 4:29:42 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: At least one test failed ❌ (JDK17) |
e61ee7a
to
e73ae62
Compare
/build_test |
Workflow started at 3/20/2024, 4:39:47 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: At least one test failed ❌ (JDK17) |
/build_test |
Workflow started at 3/20/2024, 5:28:18 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #291
This is a partial cherry-pick of a patch included in #294. This fixes the current breakage on
main
where discovery plugins (ex. Cryostat Agents) are unable to register.