-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(discovery): fix duplicate pod nodes in container discovery #420
Conversation
/build_test |
Workflow started at 4/25/2024, 7:43:38 PM. View Actions Run. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
I think the diff operation here should be done against persisted targets instead? Otherwise, if cryostat is restarted, it will cause all previously observed containers to be pruned. I will save that for another PR tho to keep this one minimal... |
I don't think it's that big of a problem, since the correct data will end up getting restored into the database again when Cryostat does come back and query the container platform again. They'll just end up with new database IDs, which seems like a minor annoyance. If you'd like to fix that in another PR I'd be happy to review it though. |
/build_test |
Workflow started at 4/26/2024, 11:46:03 AM. View Actions Run. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: All tests pass ✅ (JDK17) |
Sure! And actually, from another look, I think it would instead leave stale (removed containers) targets intact and cause duplicate key violation when cryostat comes back up again. I will work a PR for that... |
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #412
Description of the change:
FOUND
event.LOST
event, the query will return null -> NullPointerException.Motivation for the change:
See #412
How to manually test: