Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ws): simplify messaging server #424

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 27, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #423

Description of the change:

Simplifies the MessagingServer (WebSocket notifications) implementation to remove the explicit thread synchronization and message ordering.

Motivation for the change:

Using the EventBus is simpler and less error-prone than manually using synchronization features like blocking queues. Error handling is also improved in this PR, so if sending a notification to any connected client fails then this failure will be logged.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. Click around the UI performing actions and ensure notifications are still received

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Apr 27, 2024
@andrewazores andrewazores marked this pull request as ready for review April 29, 2024 13:36
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 4/29/2024, 9:40:46 AM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8879608190

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a rebasing.

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 4/30/2024, 11:40:23 AM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8897670371

@andrewazores andrewazores merged commit 8c32501 into cryostatio:main Apr 30, 2024
8 checks passed
@andrewazores andrewazores deleted the remove-messaging-server-queue branch April 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants