Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/integration test pipeline #153

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Hotfix/integration test pipeline #153

merged 6 commits into from
Aug 8, 2022

Conversation

this-kramer
Copy link
Member

Reason for this PR:

  • The integration test pipeline does not fail if the tests fail
  • Hence there were two failing integration tests without us noticing
  • Fixed it, tested by adding a failing test to ensure the pipeline actually fails

@this-kramer this-kramer added the bug Something isn't working label Aug 8, 2022
@this-kramer this-kramer self-assigned this Aug 8, 2022
@this-kramer this-kramer mentioned this pull request Aug 8, 2022
Merged
@this-kramer this-kramer merged commit 31add81 into develop Aug 8, 2022
@this-kramer this-kramer deleted the hotfix/integration-test-pipeline branch August 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanBobolz JanBobolz JanBobolz approved these changes

Assignees

@this-kramer this-kramer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@this-kramer @JanBobolz