fix(rpc): add more invalid check for fee history (backport: #1720) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| blockEnd = int64(blockNumber) | ||
| } else if int64(blockNumber) < blockEnd { | ||
| return nil, fmt.Errorf("%w: requested %d, head %d", errRequestBeyondHead, blockEnd, int64(blockNumber)) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| blockEnd = int64(blockNumber) | ||
| } else if int64(blockNumber) < blockEnd { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Codecov Report
@@ Coverage Diff @@
## release/v0.20.x-cronos #241 +/- ##
==========================================================
- Coverage 56.73% 56.68% -0.05%
==========================================================
Files 108 108
Lines 10234 10243 +9
==========================================================
Hits 5806 5806
- Misses 4181 4190 +9
Partials 247 247
|
yihuang
approved these changes
May 15, 2023
mmsqe
added a commit
that referenced
this pull request
Jun 14, 2023
* fix(rpc): nextBaseFee for fee history (backport: evmos#1720) (#234) * fix blk number for next base fee * add test * add change doc * cross check next fee * calc base fee based on params elasticity_multiplier & base_fee_change_denominator * concurrent call with maxBlockFetchers * test with get feemarket params * Update CHANGELOG.md --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com> * fix(rpc): add more invalid check for fee history (backport: evmos#1720) (#241) * align request beyond head block * align invalid reward percentile --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: yihuang <huang@crypto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/monacohq/blockchain-team-qa-documentation/issues/74 https://github.com/monacohq/blockchain-team-qa-documentation/issues/75
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)