-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CryptoBasicFileAttributes
#GH-141
#140
Conversation
the old implementation returns wrong file size for symbolic links, e.g. file `symlink` after `ln -s . symlink` should be 1
Hi, can you please:
|
leave `ciphertextFileType(DIRECTORY)` alone while fixing file size for `ciphertextFileType(SYMLINK)`
CryptoBasicFileAttributes
CryptoBasicFileAttributes
https://github.com/cryptomator/cryptofs/issues/141
CryptoBasicFileAttributes
https://github.com/cryptomator/cryptofs/issues/141CryptoBasicFileAttributes
#GH-141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the corresponding issue. The change looks reasonable, however I would like to ask you to stay with the switch statement, as with the ternary operator we lose compile-time exhaustiveness checks.
Furthermore simply moving SYMLINK
from one case to the other introduces a significantly smaller diff.
Thank you very much! |
the old implementation returns wrong file size for symbolic links, e.g. file
symlink
afterln -s . symlink
should be 1