Fixed missing localURLProvider #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the bug with the strong reference to the FileProviderExtension was fixed, the FileProviderExtension now actually deinitializes itself. Since we had only a weak reference in the FileProviderAdapter on the FileProviderExtension object, we received thereby after some time no more local URLs. This caused all actions that call an importDocument to fail.
2 tasks
2 tasks
2 tasks
tobihagemann
force-pushed
the
hotfix/fix-missing-localurlprovider
branch
from
f4dbbc2
to
7d1037a
Compare
tobihagemann
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bug with the strong reference to the FileProviderExtension was fixed in f77da62, the FileProviderExtension now actually deinitializes itself. Since we had only a weak reference in the FileProviderAdapter on the FileProviderExtension object, we received thereby after some time no more local URLs. This caused all actions that call
importDocumentto fail.Therefore, this should fix #181 , #179 and maybe even #173.