Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter transactions from get_account_history result based on block number #236

Closed
theoreticalbts opened this issue Aug 17, 2015 · 2 comments
Assignees

Comments

@theoreticalbts
Copy link
Contributor

Negative block number -> relative to head

@theoreticalbts theoreticalbts self-assigned this Aug 17, 2015
@theoreticalbts
Copy link
Contributor Author

Allowing negative block numbers for relative to head is a bad idea -- the client will likely want to track block numbers on its own.

We need a new index of (account ID, block number) -> operation_history_id where the ohid is the last op by the account in the block. The index should be disabled unless requested on the CLI. Disabling will increase performance but get_account_confirmed_history() will not be able to query based on block number.

@vikramrajkumar
Copy link
Contributor

This issue was moved to bitshares/bitshares-core#61

pmconrad pushed a commit to pmconrad/graphene that referenced this issue May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants