Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arch/gcc7 compile errors #42

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vkobel
Copy link

@vkobel vkobel commented Jun 19, 2017

This is fixing few issues people have when trying to compile under Arch Linux with gcc6 or 7. The one in src/crypto/crypto.cpp is the interesting one as many people weren't able to fix it.

@dirtyvader
Copy link

Thanks for this patch.

euleausberlin added a commit to euleausberlin/infocoin that referenced this pull request Jul 20, 2017
@euleausberlin
Copy link

Typo in 506c17e , Cryptoupnpc-static should be Crypto upnpc-static

Thanks a lot

Copy link

@SoraKohaku SoraKohaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Technohacker
Copy link

What checks are left to accept this PR?

@SoraKohaku
Copy link

not sure

delphiserg added a commit to delphiserg/jspcoin that referenced this pull request Dec 22, 2017
@rainmanp7
Copy link

rainmanp7 commented Feb 1, 2018

Thia is fixed now ;-)
Do not ignore this part and don't throw code to make the compiler ignore it.
Make the code right ;-)
It's the problem of where it's being called from ,can not be the same as the above code in the file.

@SoraKohaku
Copy link

SoraKohaku commented Feb 1, 2018 via email

Copy link

@gsquaredxc gsquaredxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Can you throw in the Mac fix? #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants