Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor simple_https_server and add self-test. #46

Merged
merged 18 commits into from
Sep 26, 2022
Merged

Refactor simple_https_server and add self-test. #46

merged 18 commits into from
Sep 26, 2022

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Sep 19, 2022

This PR partially addresses #7 as it implements the self-test.

The functions read_bytes, read_record, put_record, and get_ccs_message were replaced by the RecordStream implementation as already done for the client code. Thus, client and server now share functionality.

Motivation and Context

The refactoring is required to make the Bertie server code callable via Rust.

Checklist

  • I have linked an issue to this PR (partial fix only)
  • I have described the changes
  • I have read and understood the code of conduct, contribution guidelines, and contributor license agreement
  • I have added tests for all changes
  • I have tested that all tests pass locally and all checks pass
  • I have updated documentation if necessary

@duesee
refactor: Extract reusable code from simple_https_client to new `ba…
8563940 
…se` workspace member.

Note: In the next step that code will be reused by `simple_https_server`.
@duesee
refactor: Use code from base in simple_https_server.
98dbd5e
@duesee
refactor: Rename ClientError to AppError.
b778c5d 
Note: This is used in both client and server.
@duesee
refactor: Make tls13server a library function.
ebfff7e 
Note: This is used in the next commit to implement the self-test.
@duesee
fix: Increase timeout value to make self-test work in debug mode.
35ccc45
@duesee
tests: Add Bertie self-test.
c29ad44 
Test if Bertie's `simple_https_client` can finish the handshake with
Bertie's `simple_https_server`.
@duesee duesee requested a review from a team as a code owner September 19, 2022 11:25
franziskuskiefer
franziskuskiefer requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good to me. But can you add some description to the new crate and some of the new things?

base/Cargo.toml Outdated Show resolved Hide resolved
base/Cargo.toml Outdated Show resolved Hide resolved
base/src/lib.rs Outdated Show resolved Hide resolved
simple_https_server/src/lib.rs Show resolved Hide resolved
simple_https_server/src/lib.rs Show resolved Hide resolved
simple_https_server/src/lib.rs Outdated Show resolved Hide resolved
simple_https_server/src/lib.rs Show resolved Hide resolved
@duesee duesee mentioned this pull request Sep 21, 2022
Open
3 tasks
franziskuskiefer
franziskuskiefer requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's somehow resolve the last remaining comment, then this is good to go.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
simple_https_server/src/lib.rs Outdated Show resolved Hide resolved
duesee and others added 6 commits September 22, 2022 10:43
@duesee @franziskuskiefer
Update README.md
cd18bbb 
Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
@duesee @franziskuskiefer
Update README.md
6f277ae 
Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
@duesee
refactor: Merge tls13server into main.
db1597a
@duesee
refactor: Rename tls13server_aux to tls13server.
63264b6
@duesee
Improve main of simple_https_server.
e51fff4 
* Cleanup
* Add tracing
* Handle errors better
@franziskuskiefer
cleanup - fix some clippy warnings
9292f58
@franziskuskiefer franziskuskiefer enabled auto-merge (rebase) September 26, 2022 09:01
@franziskuskiefer franziskuskiefer merged commit 6858c35 into main Sep 26, 2022
@franziskuskiefer franziskuskiefer deleted the duesee_tests_self_test branch September 26, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duesee @franziskuskiefer