Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint/Formatting rule #326

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Add Lint/Formatting rule #326

merged 2 commits into from
Dec 20, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 19, 2022

This rule will allow to drop crystal tool format --check CI job, making it one of the rules instead.

Reopens #49

@Sija Sija added the rule label Dec 19, 2022
@Sija Sija added this to the 1.4.0 milestone Dec 19, 2022
@Sija Sija requested a review from veelenga December 19, 2022 16:37
@Sija Sija self-assigned this Dec 19, 2022
@Sija Sija marked this pull request as ready for review December 19, 2022 19:01
@Sija Sija requested a review from veelenga December 19, 2022 19:01
@Sija Sija force-pushed the Sija/lint-formatting branch 5 times, most recently from bdcd6e7 to 320a3f0 Compare December 20, 2022 02:27
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Sija Sija merged commit cabf203 into master Dec 20, 2022
@Sija Sija deleted the Sija/lint-formatting branch December 20, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants