Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5: Add StrategicPointMenu scene in scenes folder #21

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Issue #5: Add StrategicPointMenu scene in scenes folder #21

merged 3 commits into from
Oct 3, 2020

Conversation

Sop-S
Copy link
Contributor

@Sop-S Sop-S commented Oct 3, 2020

Before submitting a Pull Request please read and tick this checkbox:

and I agree with my content (code, assets, documentation,...) being licensed under the same conditions.

Created a new scene named strategic-point-menu with a placeholder for slots.
@Sop-S Sop-S changed the title Add StrategicPointMenu scene in scenes folder Issue #5: Add StrategicPointMenu scene in scenes folder Oct 3, 2020
@davcri
Copy link
Member

davcri commented Oct 3, 2020

Thanks for your pull request @Sop-S! I just merged it into master.

The strategic point menu is fine!

Also I noticed that I didn't write any convention about node names in the README, I'm going to do it.
I like using CamelCase style for node names because it's easier to reference nodes via GDScript. When using the dollar operator you can simply type $SlotTopLeft to get a reference to that node, but using the dash symbol in the node name forces you to write $"slot-top-left" using the quotes.

@davcri davcri merged commit 6610bcb into crystal-bit:master Oct 3, 2020
@davcri
Copy link
Member

davcri commented Oct 3, 2020

@Sop-S I just added your username to the credits.gd script, so that your username will appear in the game credits! If you don't want to appear, or if you want to change the displayed name just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants