Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__END_LINE__ is not scoped as a a magic constant. #38

Closed
faultyserver opened this issue Feb 27, 2018 · 0 comments
Closed

__END_LINE__ is not scoped as a a magic constant. #38

faultyserver opened this issue Feb 27, 2018 · 0 comments
Labels
bug

Comments

@faultyserver
Copy link
Contributor

screen shot 2018-02-26 at 8 52 39 pm

As the image above shows, the magic constant __END_LINE__ (introduced in 0.20.0) is not currently being recognized by the syntax definition.

It should be scoped with variable.language.crystal to match __LINE__, and __FILE__.
@faustinoaq faustinoaq added the bug label Apr 6, 2018
@faultyserver faultyserver mentioned this issue Jun 26, 2018
Merged
faultyserver added a commit to faultyserver/sublime-crystal that referenced this issue Jun 26, 2018
@faultyserver
Fixes crystal-lang-tools#38. Scope __END_LINE__ magic constant as `…
c74f111 
…variable.language.crystal`

Added in 0.20.0, `__END_LINE__` is a magic constant that evaluates to the line number of the end location of a Node (normally a `Call`, used in method parameters). The `variable.language.crystal` scope matches the other existing magic constants: `__DIR__`, `__FILE__`, and `__LINE__`.
faultyserver added a commit to faultyserver/sublime-crystal that referenced this issue Oct 2, 2018
@faultyserver
Fixes crystal-lang-tools#38. Scope __END_LINE__ magic constant as `…
4e10da8 
…variable.language.crystal`

Added in 0.20.0, `__END_LINE__` is a magic constant that evaluates to the line number of the end location of a Node (normally a `Call`, used in method parameters). The `variable.language.crystal` scope matches the other existing magic constants: `__DIR__`, `__FILE__`, and `__LINE__`.
hovsater added a commit that referenced this issue Oct 2, 2018
@hovsater
Merge pull request #48 from faultyserver/fix/various-scopes
3dfe2ff 
Scope fixes for `__END_LINE__`, `:!`, and `:!=` (fixes #37, fixes #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faultyserver @faustinoaq