Drop deprecated definitions #10386
Merged
Drop deprecated definitions #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Feb 12, 2021
|
@HertzDevil you mean reverting the name_loc forwarding to the macro interpreter, right? I think I prefer to keep those. Granted they are not used, but is a nice addition to improve error reporting in macros on future messages. The rest of those commits was reverted or adapted to annotations. |
|
Looks like we missed |
|
Yeah. But that's not a big deal. Can be removed any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are all the deprecated definitions. If some are really recent and we will prefer to keep them during 1.x please comment.
For example I am not dropping the recent alias
HTTP::Paramsmostly because there is no deprecation warning on it. But if others prefer it can be dropped in this PR also.