-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edge cases for symbol quoting rules #10389
Merged
bcardiff
merged 9 commits into
crystal-lang:master
from
HertzDevil:bug/symbol-needs-quotes
Feb 18, 2021
Merged
Fix edge cases for symbol quoting rules #10389
bcardiff
merged 9 commits into
crystal-lang:master
from
HertzDevil:bug/symbol-needs-quotes
Feb 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
changed the title
Fix edge cases for inspecting symbols
Fix edge cases for symbol quoting rules
Feb 13, 2021
straight-shoota
approved these changes
Feb 13, 2021
asterite
reviewed
Feb 17, 2021
straight-shoota
approved these changes
Feb 18, 2021
bcardiff
approved these changes
Feb 18, 2021
bcardiff
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
topic:compiler
labels
Feb 18, 2021
I merged master to resolve the conflicts due to recent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three edge cases addressed here:
:&**
shouldn't require quotes when inspected, because it is a valid operator name.:""
) should require quotes when inspected, but currently produces just:
, which is syntatically invalid. This affectsSymbolLiteral#to_s
and indirectly methods such asNamedTuple#inspect
::_
) don't require quotes in the symbol notation, they do need them when used as names (e.g. named argument keys, external parameter names). For example: