-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @top_level to access the top-level scope in macros #10682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
May 6, 2021
Co-authored-by: Ary Borenszweig <asterite@gmail.com>
asterite
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
straight-shoota
approved these changes
May 6, 2021
straight-shoota
changed the title
Adding @top_level to access de program in macros
Add @top_level to access the top-level scope in macros
May 12, 2021
Gracias, @beta-ziliani |
beta-ziliani
added a commit
to beta-ziliani/crystal
that referenced
this pull request
Jul 23, 2021
… module 'main', as it was in 1.0.0
straight-shoota
pushed a commit
that referenced
this pull request
Jul 23, 2021
…n', as it was in 1.0.0
straight-shoota
pushed a commit
that referenced
this pull request
Jul 24, 2021
straight-shoota
pushed a commit
that referenced
this pull request
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8914 by creating a new instance method
@top_level
(as suggested by @jhass). This allows to query the top level module, as the following example shows: