Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Call.def_full_name print full block parameter #10915

Conversation

straight-shoota
Copy link
Member

Call.def_full_name prints the signature of a method. It's used in error messages about undefined methods and missing / incorrect implementation of abstract defs. The method did not show the type restriction of a block parameter, while all other parameter's type restrictions are shown. This patch makes sure to print block parameters with type restriction.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Jul 9, 2021
@beta-ziliani beta-ziliani added this to the 1.2.0 milestone Sep 6, 2021
@straight-shoota straight-shoota merged commit 305db80 into crystal-lang:master Sep 7, 2021
@straight-shoota straight-shoota deleted the fix/def_full_name-block-parameter branch September 7, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants