Compiler: fix is_a? for virtual metaclass types
#11121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
commented
Aug 23, 2021
| @@ -82,7 +82,16 @@ module Crystal | |||
| return nil if type1.instance_type.module? | |||
|
|
|||
| restricted = common_descendent(type1.instance_type, type2.instance_type.base_type) | |||
| restricted ? type1 : nil | |||
| restricted.try(&.virtual_type.metaclass) | |||
There was a problem hiding this comment.
I changed this because restricting a type against a virtual type should always give a possibly virtual type: we don't know which of the actual subtypes it will be.
straight-shoota
approved these changes
Aug 23, 2021
asterite
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11120
There are comments around further improvements to the type system, but they can be done later and independent of this PR (it's a really small change here.)