Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Process specs #12889

Conversation

straight-shoota
Copy link
Member

Re-order and structure process_spec. Also extract specs for utility methods that are not part of the Process model into a separate file for a clear arrangement.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor suggestion.

spec/std/process_spec.cr Outdated Show resolved Hide resolved
Co-authored-by: Beta Ziliani <beta@manas.tech>
@straight-shoota straight-shoota added this to the 1.7.0 milestone Jan 2, 2023
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@straight-shoota straight-shoota merged commit 74a7cd2 into crystal-lang:master Jan 3, 2023
@straight-shoota straight-shoota deleted the spec/refactor-process-specs branch January 3, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants