Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hostname spec if hostname command fails #12987

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

Blacksmoke16
Copy link
Member

Avoids a spec failure if the hostname command is unavailable. Which apparently it's not on my machine 😅.

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:system labels Jan 21, 2023
@straight-shoota straight-shoota added this to the 1.8.0 milestone Jan 21, 2023
@straight-shoota straight-shoota changed the title Ensure hostname command exists before running spec that uses it Skip hostname spec if hostname command fails Jan 22, 2023
@straight-shoota straight-shoota merged commit 498abb4 into crystal-lang:master Jan 24, 2023
@Blacksmoke16 Blacksmoke16 deleted the hostname-cmd-fix branch January 24, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants