Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Sanitize doc generation" #14595

Merged
merged 1 commit into from
May 15, 2024

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented May 15, 2024

Reverts #13786

We failed to notice that this commit added a dependency on libxml2 to the compiler.
Because this library is unavailable, builds are breaking: https://app.circleci.com/pipelines/github/crystal-lang/crystal/14924/workflows/dc50e27f-1e26-4e77-adaa-a1fa925925a9

So we'll need to revert and prepare better before introducing it again (#13753).

@straight-shoota straight-shoota added this to the 1.13.0 milestone May 15, 2024
@straight-shoota straight-shoota merged commit 5f0e390 into master May 15, 2024
122 checks passed
@straight-shoota straight-shoota deleted the revert-13786-nobody/sanitize-docs branch May 15, 2024 14:57
@straight-shoota straight-shoota removed this from the 1.13.0 milestone Jun 14, 2024
@straight-shoota straight-shoota added the status:reverted PR was reverted or reverts another one, and is not part of a milestone label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:chore status:reverted PR was reverted or reverts another one, and is not part of a milestone topic:tools:docs-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants