Macros: automatically resolve alias in types #4995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4301
This makes is so that if
T
is a (non-recursive) alias type, usingT
in macros automatically resolved to the aliased type. With this we can now do (for example):This can greatly simply code. For example here:
crystal/src/json/from_json.cr
Line 69 in 74050a4
An alternative implementation would be to add a macro method to solve an alias type. But alias types in regular code can never be reached by the user: trying to use one immediately uses the underlying type. So doing the same thing in macros is consistent. For example:
There's simply now way to make a program print "Foo" at runtime by using that alias, because trying to use it will solve to
Int32
.