Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tuple#map_with_index return a Tuple. #5086

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Make Tuple#map_with_index return a Tuple. #5086

merged 1 commit into from
Oct 7, 2017

Conversation

firejox
Copy link
Contributor

@firejox firejox commented Oct 7, 2017

According to issue #683, I think map_with_index should also return Tuple

@jkthorne
Copy link
Contributor

jkthorne commented Oct 7, 2017

This seems really useful +1

@RX14 RX14 merged commit ebe683c into crystal-lang:master Oct 7, 2017
@RX14 RX14 added this to the Next milestone Oct 7, 2017
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels Oct 7, 2017
@firejox firejox deleted the tuple_unified_map_behavior branch October 15, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@firejox @jkthorne @bcardiff @RX14