Fix docs path in .gitignore and Makefile #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
jm-fix-docs-path
branch
from
07a9046
to
42a7421
Compare
asterite
approved these changes
Oct 31, 2017
luislavena
suggested changes
Oct 31, 2017
There was a problem hiding this comment.
Hello @straight-shoota, thank you for the PR. You might also need to update bin/ci:
https://github.com/crystal-lang/crystal/blob/master/bin/ci#L87
And the AWS S3 sync of documentation part:
https://github.com/crystal-lang/crystal/blob/master/bin/ci#L95-L99
|
Thanks @luislavena! I was grepping through the repo to see if there are some other uses of |
luislavena
approved these changes
Oct 31, 2017
RX14
approved these changes
Oct 31, 2017
asterite
approved these changes
Oct 31, 2017
RX14
added
kind:bug
Merged
veelenga
added a commit
to crystal-ameba/ameba
that referenced
this pull request
Dec 26, 2017
azomazo
added a commit
to azomazo/gentoo
that referenced
this pull request
Jan 9, 2018
In PR crystal-lang/crystal#5217 directory doc renamed to docs Package-Manager: Portage-2.3.19, Repoman-2.3.6
azomazo
added a commit
to azomazo/gentoo
that referenced
this pull request
Jan 9, 2018
In PR crystal-lang/crystal#5217 directory doc renamed to docs Package-Manager: Portage-2.3.19, Repoman-2.3.6
azomazo
added a commit
to azomazo/gentoo
that referenced
this pull request
Jan 9, 2018
In PR crystal-lang/crystal#5217 directory doc renamed to docs Package-Manager: Portage-2.3.19, Repoman-2.3.6
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 9, 2018
In PR crystal-lang/crystal#5217 directory doc renamed to docs Package-Manager: Portage-2.3.19, Repoman-2.3.6 Closes: #6810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4937 changed the default location for
crystal docsto./docs, this RP applies this rename to .gitignore and Makefile.