-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler: store and restore debug location when going to main #8234
Conversation
16c9367
to
2a22818
Compare
Woo hoo! This is awesome. I’ve run into this a couple times |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! Lets make it to 0.31.1
@bcardiff When do you think 0.31.1 could be released. Right now we're blocked on releasing a new version of Lucky because we can't shutdown HTTP servers/chromedriver in specs (due to the specs being run in Long story short, if this was released we'd be able to get a new version of Lucky out with support for the newest Crystal. Don't want to pressure anything, just explain the situation and see if that may affect the release cycle. Or if you have some ideas for helping us that'd be great too Here is what we're doing now that requires cc @jwoertink |
I can try to run this against master and see how that goes. |
@paulcsmith What do we need from |
Oh, I just see #8235 |
Ok, so I ran 2 different repos that had this issue against master, and both of them give me the same response:
But both of these throw the module validation error with 0.31.0, so progress! 😄 |
@asterite Yes the @jwoertink sometimes using Crystal master doesn't get the paths quite right when run like that so I'm guessing there is something up there but I don't know the fix. I think you can mv the built binary to |
@paulcsmith I tried moving the binary to
I ran |
The way to do it is to invoke
That To simplify things I have an alias
Let me know if using any of those methods works for you guys with |
@paulcsmith there are two outstanding regressions / bugs I would like to try fix before 0.31.1 #8230 and #8231 . If things go smooth we should be ready for a release tomorrow or on Monday. |
That’s great news! Thanks @bcardiff
… On Sep 26, 2019, at 9:26 AM, Brian J. Cardiff ***@***.***> wrote:
@paulcsmith there are two outstanding regressions / bugs I would like to try fix before 0.31.1 #8230 and #8231 . If things go smooth we should be ready for a release tomorrow or on Monday.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Compiler: store and restore debug location when going to main
#1 should be resolved by crystal-lang/crystal#8234
#1 should be resolved by crystal-lang/crystal#8234
Fixes #8233
Fixes #7060
Fixes #6920
(which are all just the same bug, but this way it looks like this is a killer PR! 😛)
@bcardiff I'm putting this for 0.31.1 because even though it's not a bug introduced there, it's something that will likely fix a lot of the existing issues with debug info.