treat SSL connection that doesn't terminate SSL but gracefully termin… #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Dec 3, 2019
Sija
reviewed
Dec 3, 2019
|
OK this causes a hang in the unit tests on Linux, investigating... |
RX14
approved these changes
Dec 7, 2019
|
This is basically kind of blocked until #8582 is resolved |
RX14
approved these changes
Dec 16, 2019
|
OK ready for review now, the unit tests pass in Linux now :) |
|
@rdp I'm afraid I need to ask for a rebase on master. The PR currently shows lots of other changes altogether. |
…ates the underlying connection as an EOF crystal-lang#7383
Co-Authored-By: Sijawusz Pur Rahnama <sija@sija.pl>
|
OK should be ready for review |
straight-shoota
approved these changes
Dec 18, 2019
straight-shoota
added
kind:bug
RX14
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ates the underlying connection as an EOF #7383