Top level exception handler #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waj
added
kind:bug
RX14
approved these changes
Feb 7, 2020
|
Can we merge this for |
|
There is a need to a dprintf replacement for Windows. We were thinking of adding a method in the Crystal namespace that will mimic a dprintf in Windows. That's the thing that is missing to avoid breaking the build. |
waj
force-pushed
the
fix/main-exception-handler
branch
from
76b5153
to
3c12033
Compare
Sija
reviewed
Feb 11, 2020
| @@ -96,6 +98,26 @@ module Crystal | |||
| def self.main_user_code(argc : Int32, argv : UInt8**) | |||
| LibCrystalMain.__crystal_main(argc, argv) | |||
| end | |||
|
|
|||
| protected def self.handle_exceptions | |||
| begin | |||
There was a problem hiding this comment.
begin ... end pair is redundant here.
bcardiff
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many issues where the reported error contains a
Failed to raise an exception: END_OF_STACK. Many times this is because an error happens outside thebegin/rescuearound__crystal_mainand it ends hiding the real source of the issue. (#8387, #6249, #7810, among others)I added this exception handler a the top level of
Crystal.mainto dump the unhandled exception. I tried to be as conservative as possible, executing the least amount of Crystal's std code.