HTTP::Cookie: parse max-age as Int64, not Int32 #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
spec/std/http/cookie_spec.cr
Outdated
| it "parses large max-age (#8744)" do | ||
| cookie = parse_set_cookie("a=1; max-age=3153600000") | ||
| delta = cookie.expires.not_nil! - Time.utc | ||
| delta.should be > (3153600000 - 1).seconds |
There was a problem hiding this comment.
Why not use be_close expectation?
There was a problem hiding this comment.
I copied the code from the previous spec without too much thought.
There was a problem hiding this comment.
I changed it to use be_close
straight-shoota
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8744
I considered parsing it as UInt64 too, but if max-age is
Int64::MAXit already overflows when trying to create a time instance, so Int64 is probably fine.(or put another way, in the rare case it breaks with a much bigger number let's tackle that later)