Try to open stdio in non-blocking mode #8787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the stdio descriptors are not a TTY they are re-opened with
blocking: true
. That makes sense for files, for example if the output is being redirected (i.e:./foo > somefile
). But it doesn't if the input is a pipe (i.e:cat | ./foo
).The problem is that programs like this will block all the fibers:
We used to have problems with stdio (#2713) but it was fixed by not changing the blocking mode from the original file descriptor (#6518)
This PR adds a third state to the
blocking
argument ofFileDescriptor.new
. When anil
is passed (the default) it detects the type of descriptor and sets the blocking mode accordingly.Unfortunately this is quite difficult to test, so there is no specs to find regressions. I added a spec to check the STDIN opens in different modes depending on the fd type. But please, help me find if I didn't miss anything and I'm actually breaking everything again 😅