Remove DL module #8882
Merged
Remove DL module #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Mar 5, 2020
|
|
||
| module DL | ||
| def self.dlopen(path, mode = LibC::RTLD_LAZY | LibC::RTLD_GLOBAL) : Void* | ||
| LibC.dlopen(path, mode) |
There was a problem hiding this comment.
Should we remove the fun definitions for dlopen too?
|
Should be removed from Deprecating it wouldn't hurt either, people might be using it because it's documented. |
|
In this case I think there is no need for a deprecation cycle. The module is most likely not used in the wild. But we can go that route if that is preferred. I'll wait for reviews. |
|
I couldn't find any single usage in Crystal repositories available on Github. So I guess it's fine to remove without deprecation (there's certainly Crystal code outside of Github, but it's a very strong indicator that there is really no real world use). |
asterite
approved these changes
Mar 6, 2020
jhass
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is no longer used, nor included in prelude, and does not offer much functionality.