HTTP server do SSL handshake in client fiber #9177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le automatic SSL handshake on `accept`
Sija
reviewed
Apr 25, 2020
|
Just added a spec and fixed the segfaults due to a double SSL_free call. Because now the |
straight-shoota
previously approved these changes
Apr 26, 2020
jhass
previously approved these changes
Apr 26, 2020
RX14
reviewed
Apr 26, 2020
| raise ex | ||
| end | ||
|
|
||
| def accept |
There was a problem hiding this comment.
Isn't this a breaking change for people using OpenSSL::SSL::Socket::Server?
There was a problem hiding this comment.
That's true. I just refactored this fix so it doesn't break compatibility. Thanks!
RX14
previously approved these changes
Apr 26, 2020
|
@RX14 I agree with you, like I do with @straight-shoota. I just did the smallest change to fix this bug with the current design, but I'm also with you in that these wrappers around OpenSSL api is not ideal. |
straight-shoota
approved these changes
Apr 26, 2020
|
Great! |
RX14
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8108 by forcing the call to
SSL_acceptwithin the fiber that handles the request.To implement this fix, I added the
OpenSSL::SSL::Server#start_immediatelyproperty just like Ruby does: https://ruby-doc.org/stdlib-2.5.1/libdoc/openssl/rdoc/OpenSSL/SSL/SSLServer.html