Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TypeNode.name(generic_args: false) for generic instances #9224

Merged
merged 1 commit into from
May 7, 2020
Merged

Support TypeNode.name(generic_args: false) for generic instances #9224

merged 1 commit into from
May 7, 2020

Conversation

Blacksmoke16
Copy link
Member

Fixes #9223

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:macros labels May 4, 2020
@bcardiff bcardiff added this to the 0.35.0 milestone May 4, 2020
@straight-shoota straight-shoota merged commit d27f524 into crystal-lang:master May 7, 2020
@straight-shoota
Copy link
Member

Thank you, @Blacksmoke16

@Blacksmoke16 Blacksmoke16 deleted the generic-instance-type-names branch May 7, 2020 16:40
@HertzDevil HertzDevil mentioned this pull request Aug 18, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:macros
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

TypeNode with generic_args as false doesn't omit populated types
4 participants
@Blacksmoke16 @straight-shoota @jhass @bcardiff