Add docs to string methods in SymbolLiteral and MacroId
#9298
Conversation
…oId` Because their methods delegates to `StringLiteral`. In fact, `SymbolLiteral#underscore` and `MacroId#underscore` are missing in document. It should be shared.
makenowjust
force-pushed
the
string-literal-macro-doc
branch
from
7e1e7b3
to
6ae7ca0
Compare
|
Follow #9269 changes. |
|
ping |
|
Any reasons against using a generic module instead of a macro? |
|
Because they don't include any |
|
I don't quite understand, I mean having something like |
|
It won't make sense. Such hierarchy doesn't exist in the compiler. The type doesn't exist in macros. |
|
Repeat from the above PR description, current documentation misses |
straight-shoota
added
kind:docs
kind:feature
topic:lang:macros
and removed
kind:feature
labels
src/compiler/crystal/macros.cr
Outdated
| # Similar to `String#>` | ||
| def >(other : StringLiteral | MacroId) : BoolLiteral | ||
| end | ||
|
|
||
| # Similar to `String#<` | ||
| def <(other : StringLiteral | MacroId) : BoolLiteral | ||
| end |
There was a problem hiding this comment.
SymbolLiteral doesn't have < > methods.
The rest seems to be good.
There was a problem hiding this comment.
Sorry for my slow response. This is fixed.
straight-shoota
changed the title
StringLiteral methods document with SymbolLiteral and MacroIdSymbolLiteral and MacroId
Because their methods delegates to
StringLiteral. In fact,SymbolLiteral#underscoreandMacroId#underscoreare missing in document. It should be shared.In details, it uses a file
privatemacro nameddef_string_methods.Thank you.