Allow executing OpAssign (+=, ||=, etc.) inside macros #9409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
Blacksmoke16
reviewed
Jun 4, 2020
| @@ -318,6 +318,10 @@ module Crystal | |||
| false | |||
| end | |||
|
|
|||
| def visit(node : OpAssign) | |||
| @program.normalize(node).accept(self) | |||
There was a problem hiding this comment.
Just for my own learning; last time you implemented this in cf35077 you had false as the return value. What's the reasoning behind including that or not?
There was a problem hiding this comment.
Can the visit methods also return true?
asterite
force-pushed
the
bug/op-assign-in-macros
branch
from
69535ce
to
2bba7ae
Compare
grepsedawk
added a commit
to grepsedawk/athena
that referenced
this pull request
Feb 21, 2022
crystal-lang/crystal#9409 was merged, adding support for ||= in macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9356