Restore debug level information in specs to fix 32 bits builds #9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collect memory within ensure block fails when --debug is used on 32bits
Something pending is that now the CRYSTAL_SPEC_COMPILER_FLAGS are not used since program_flags_options is not called.
waj
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9463
Working job with the 0.35.0 https://circleci.com/gh/crystal-lang/crystal/48211
The underlying cause is that
LibC.statis not working on 32 bits environment when the path refers to mounted volume (like the docker mounted volume used to share the working copy in the ci, or vagrant shared file). This is seems to be an old issue cause it happens with older compilers also.Due to the recent refactors #9294 some examples were now compiled with full debug information and that caused the issue. So this PR reverts the spec to use the flags as before.
The call_stack_spec was using full debug information, but they also failed on 32 bits unless the default debug information level is used. Maybe this was due to the recent debug additions.