Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reference to Kernel. #9549

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

toddsundsted
Copy link
Contributor

Removes a reference to the Kernel module, which does not exist in Crystal.

src/io.cr Outdated
@@ -259,7 +259,7 @@ abstract class IO
end

# Writes a formatted string to this IO.
# For details on the format string, see `Kernel::sprintf`.
# For details on the format string, see top-level `sprintf`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# For details on the format string, see top-level `sprintf`.
# For details on the format string, see top-level `printf`.

Copy link
Contributor Author

@toddsundsted toddsundsted Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! fixed in 8ece9e1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the policy/preference on squashing commits to clean up PRs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work, that will point to printf in IO. You need to use ::printf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The policy is you don't care about how many commits are in here, we always squash PRs before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! fixed in 3ceb8ff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't generate a link to the top-level doc page, but it does prevent a link internal to the class

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe it's not implemented in the doc generator... I guess leaving it like that is good for now.

@jhass jhass added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs labels Jun 26, 2020
@jhass jhass requested a review from asterite June 29, 2020 14:18
@asterite asterite added this to the 1.0.0 milestone Jun 29, 2020
@asterite asterite merged commit 9d15c53 into crystal-lang:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants