-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Reference to Kernel
.
#9549
Conversation
src/io.cr
Outdated
@@ -259,7 +259,7 @@ abstract class IO | |||
end | |||
|
|||
# Writes a formatted string to this IO. | |||
# For details on the format string, see `Kernel::sprintf`. | |||
# For details on the format string, see top-level `sprintf`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# For details on the format string, see top-level `sprintf`. | |
# For details on the format string, see top-level `printf`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! fixed in 8ece9e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the policy/preference on squashing commits to clean up PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work, that will point to printf
in IO. You need to use ::printf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The policy is you don't care about how many commits are in here, we always squash PRs before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! fixed in 3ceb8ff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't generate a link to the top-level doc page, but it does prevent a link internal to the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe it's not implemented in the doc generator... I guess leaving it like that is good for now.
Removes a reference to the
Kernel
module, which does not exist in Crystal.