Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format dependency and requirements #358

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Format dependency and requirements #358

merged 2 commits into from
Apr 19, 2020

Conversation

waj
Copy link
Member

@waj waj commented Apr 17, 2020

Since #354, the reporting of conflicts didn't look nice. Now it looks back again like this:

$ shards install
Resolving dependencies
Unable to satisfy the following requirements:

- `db (0.2.0)` required by `shard.yml`
- `db (~> 0.1.0)` required by `mysql 0.1.0`
Failed to resolve dependencies

straight-shoota
straight-shoota reviewed Apr 17, 2020
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration spec to ensure changes to the user experience won't go unnoticed again?

@waj
Copy link
Member Author

waj commented Apr 18, 2020

Could you add an integration spec to ensure changes to the user experience won't go unnoticed again?

@straight-shoota done!

@waj waj merged commit 80ed079 into crystal-lang:master Apr 19, 2020
@waj waj deleted the fix/dependency-formatting branch April 19, 2020 03:21
@bcardiff bcardiff added this to the v0.11.0 milestone May 27, 2020
taylor pushed a commit to vulk/shards that referenced this pull request Aug 11, 2020
@waj @taylor
Format dependency and requirements (crystal-lang#358)
3f887af
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
@waj
Format dependency and requirements (crystal-lang#358)
74e255d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@waj @bcardiff @straight-shoota