Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write lockfile even when there are no dependencies #453

Merged

Conversation

straight-shoota
Copy link
Member

With this change shards update and shards install (except with --production option) always write shard.lock (or touch if there are not changes) even if there are no dependencies.

Resolves #445
Unlocks #444

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much love inspired by Makefiles :-)

@straight-shoota straight-shoota merged commit e63574c into crystal-lang:master Dec 12, 2020
@straight-shoota straight-shoota deleted the feature/lockfile-always branch December 12, 2020 15:07
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
@bcardiff bcardiff added this to the vNext milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lockfile is not overridden when dependencies are removed
2 participants