Add --skip-executables
#506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
--skip-executablesflag for theinstallandupdatecommands which disables installing files defined asexecutablesin anyshard.ymlThis is a minimal solution for #498 with behaviour I think we can all agree on.
I would go one step further and also imply this flag when
--skip-postinstallis used, because executables are typically built by postinstall hooks and if they're not executed, installing the executables will fail (see #498 (comment)).But this is not strictly necessary for this PR, we can at least provide an option (even if it's more lengthy) to skip installation of executables.
The manpages diff is big and contains unrelated changes because of #505, which is included as the first commit here and thus should be merged first.