Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enabled ~ support in path resolver #538

Merged
merged 3 commits into from
Mar 22, 2022
Merged

re-enabled ~ support in path resolver #538

merged 3 commits into from
Mar 22, 2022

Conversation

masukomi
Copy link
Contributor

@masukomi masukomi commented Dec 31, 2021

Resolves #308

as per suggestion of @ysbaddaden

⚠️ WARNING: I just did what was suggested. It seems to compile, but I did not actually unit test this because most of the unit tests fail for me without any changes on my part.

@straight-shoota
Copy link
Member

I added a spec and fixed the implementation File.expand_path requires tilde expansion explicitly enabled (home: true).

@straight-shoota
Copy link
Member

Note: Besides enabling support for tilde expansion, this also improves the error message for nonexistent paths. When the path doesn't exist, you currently get the error Missing "shard.yml" for "nonexistent". With this change it will be Failed no such path: non/existent/path.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beta-ziliani beta-ziliani added this to the v0.17.0 milestone Mar 21, 2022
@straight-shoota straight-shoota merged commit c477c37 into crystal-lang:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't support ~ in path
3 participants