prune - Don't raise an exception if install_path doesn't exist #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exists before trying to iterate over its children. Performing this check will avoid raising an uncaught exception when running `shards prune` if a `shards.lock` file exists but the `Shards.install_path` directory does not.
…ll_path dir has been deleted
straight-shoota
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if you run
shards prunein a project with the following two conditions:shards.lockexistslib/) does not existThen the command raises an exception. This might not be a super common scenario, but in the context of CI it can be frustrating for this command to throw and then interrupt the whole job rather than just not doing anything.