Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit the standard input descriptor #561

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

hovsater
Copy link
Contributor

@hovsater hovsater commented Oct 5, 2022

When running shards run, you should be able to work with standard input.

Fix #550

When running `shards run`, you should be able to work with standard
input.
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome first contribution.

Thanks for picking this up =)

@straight-shoota straight-shoota merged commit 603ac12 into crystal-lang:master Oct 27, 2022
@straight-shoota straight-shoota added this to the 0.17.2 milestone Dec 21, 2022
@Blacksmoke16
Copy link
Member

In one of my projects I'm using stty to get the size of the terminal. When running via shards run I noticed it prints stty: 'standard input': Inappropriate ioctl for device to standard error, while building and running it does not.

My understanding is it should be using the same IO, so they should be equivalent? I don't think it really hurts anything so could just silence STDERR and not worry about it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard input file descriptor immediately closed when running a program using shards run
4 participants