Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry related commands #85

Closed
wants to merge 3 commits into from
Closed

Registry related commands #85

wants to merge 3 commits into from

Conversation

ysbaddaden
Copy link
Contributor

@ysbaddaden ysbaddaden self-assigned this Jan 16, 2016
@asterite
Copy link
Member

👍

@jayvdb
Copy link

jayvdb commented Jul 30, 2018

ping @ysbaddaden , these are really important commands to have.

@RX14
Copy link
Contributor

RX14 commented Jul 30, 2018

@jayvdb Shards doesn't have a registry and it won't be getting one. You can search for shards using https://crystalshards.xyz/

@RX14 RX14 closed this Jul 30, 2018
@straight-shoota
Copy link
Member

@RX14 Closing this PR is not a good approach. The issues requesting this (#86 and #87) are still open, so you just declined this implementation. IMHO these are valid feature requests, even without a registry. And they even come from the main contributer.

Shards doesn't have a centralized registry. But it has resolvers with access to shard repositories (github, gitlab, bitbucket). It would be easy to be able to query these resolvers about available shards. Providing this with the CLI would be a nice alternative to going through an external website (context switch and all). This could well be implemented with an additional tool, but I don't see a reason why shards itself shouldn't be able to query resolvers for available shards.

The command interface could look like this:

# search in github resolver
shards github search foo
# search in all available resolvers
shards search foo

@RX14
Copy link
Contributor

RX14 commented Aug 1, 2018

@straight-shoota either way this is a PR from two and a half years ago, which interfaces with an API that doesn't exist. I don't think its getting merged any time soon.

I didn't close the issues, I just closed this PR.

@ysbaddaden ysbaddaden deleted the feature/registry branch August 1, 2018 12:42
@straight-shoota
Copy link
Member

You're right. But your comment sounded like an explanation to close the issues.

@jayvdb
Copy link

jayvdb commented Aug 1, 2018

Thanks. I am happy to get clarification on how this will proceed if this PR isnt it.

For context, @coala is building a shard manager (wrapper) at https://gitlab.com/coala/package_manager/merge_requests/150 , and we need to know whether a shard is locally installed (shard list) and we'll soon want to be knowing if a latter package has been released, without updating it, which I assumed shard info would have given us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants