Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calls to print with logging that can be enabled/disabled #4

Closed
joshwatson opened this issue Oct 2, 2018 · 0 comments · Fixed by #13
Closed

Replace calls to print with logging that can be enabled/disabled #4

joshwatson opened this issue Oct 2, 2018 · 0 comments · Fixed by #13

Comments

@joshwatson
Copy link
Contributor

I would prefer if the module itself did not have any calls to print in it. If having some output about analysis outside of __main__ blocks is necessary, it would be better to use some sort of logging that can be customized or completely ignored without having to try to do stdout redirection.
montyly added a commit that referenced this issue Nov 30, 2018
@montyly
Improve documentation (#8)
f581588 
- Improve Readme
- Add library usage
Improve API (#7)
- Create command line arguments
- Improve CFG module API
Use logging (close #4)
@montyly montyly mentioned this issue Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(WIP) Open source preparation crytic/evm_cfg_builder
1 participant
@joshwatson