Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug-Candidate]: slither-flat a bug of --convert-external flag, which converts external to public in an interface #1296

Closed
TheStarBoys opened this issue Jul 21, 2022 · 0 comments · Fixed by #1308
Closed

[Bug-Candidate]: slither-flat a bug of --convert-external flag, which converts external to public in an interface #1296

TheStarBoys opened this issue Jul 21, 2022 · 0 comments · Fixed by #1308
Labels
bug-candidate Bugs reports that are not yet confirmed

Comments

@TheStarBoys
Copy link
Contributor

Describe the issue:

slither-flat 0xda2c338350a0E59Ce71CDCED9679A3A590Dd9BEC --strategy MostDerived --convert-external

You will see that external function was converted to public function in an interface called IUniswapV2Factory in a file having Stake_FXS_WETH_ prefix.

Code example to reproduce the issue:

slither-flat 0xda2c338350a0E59Ce71CDCED9679A3A590Dd9BEC --strategy MostDerived --convert-external

Version:

0.8.3

Relevant log output:

No response
@TheStarBoys TheStarBoys added the bug-candidate Bugs reports that are not yet confirmed label Jul 21, 2022
TheStarBoys added a commit to TheStarBoys/slither that referenced this issue Jul 24, 2022
@TheStarBoys
Fix crytic#1296:
8005042 
    contract.contract_kind is always None.
    So use contract.is_interface instead of contract_kind.
@0xalpharush 0xalpharush linked a pull request Jul 28, 2022 that will close this issue
Fix contract_kind #1308
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-candidate Bugs reports that are not yet confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix contract_kind crytic/slither
2 participants
@TheStarBoys @0xalpharush