Fix #2266 #2412
Fix #2266 #2412
Conversation
…not properly printed.
DarkaMaul
requested review from
montyly,
0xalpharush and
smonicas
as code owners
WalkthroughThe changes introduce improvements to the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Test as test_slithir_printer
participant Printer as PrinterSlithIR
participant Output as Output
Test->>Printer: Generate output
Printer->>Output: Create dot file
Output-->>Test: Return content
Test-->>Printer: Assert specific content
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- slither/slithir/operations/assignment.py (1 hunks)
- tests/e2e/printers/test_data/test_printer_slithir/bug-2266.sol (1 hunks)
- tests/e2e/printers/test_printers.py (2 hunks)
Additional comments not posted (3)
tests/e2e/printers/test_data/test_printer_slithir/bug-2266.sol (1)
1-13: The Solidity test filebug-2266.solis correctly set up to replicate the issue being addressed. It effectively demonstrates the assignment of a function to a local variable, which is central to the issue fixed by this PR.tests/e2e/printers/test_printers.py (1)
40-52: The test functiontest_slithir_printercorrectly implements the logic to verify the fix for thePrinterSlithIRfunctionality. However, it would be beneficial to add a comment explaining why the presence of "slither.core.solidity_types" in the output indicates a failure to correctly display function types.slither/slithir/operations/assignment.py (1)
48-63: The changes made to theAssignmentclass correctly address the issue of displaying function return types when they are used as r-values in assignments. To ensure robustness, consider adding unit tests covering both single and multiple return types scenarios.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/printers/test_printers.py (3 hunks)
Additional context used
GitHub Check: Lint Code Base
tests/e2e/printers/test_printers.py
[warning] 38-38:
C0303: Trailing whitespace (trailing-whitespace)
Additional comments not posted (3)
tests/e2e/printers/test_printers.py (3)
10-10: The import ofPrinterSlithIRis correctly placed and necessary for the new functionality.
39-39: The comment about testing the include/exclude interface behavior enhances clarity and understanding.
52-64: The newtest_slithir_printerfunction is well-implemented and covers the necessary assertions to ensure thePrinterSlithIRis functioning as expected.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/printers/test_printers.py (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/e2e/printers/test_printers.py
When a function was used as a r-value in a variable assignment, its type was not properly printed using the
slithirprinter.This PR fixes that.
It also add a test to check that this issue does not arise again. However, I'm unsure where to put this test and if we even want tests for this kind of issues.
Summary by CodeRabbit
Bug Fixes
Tests
PrinterSlithIRoutput, ensuring certain content is correctly generated.