Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore naming convention restriction on echidna_ and crytic_ functions #317

Merged
merged 2 commits into from
Aug 21, 2019
Merged

ignore naming convention restriction on echidna_ and crytic_ functions #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ba27b
ignore naming convention restriction on echidna_ and crytic_ functions
agroce Aug 20, 2019
5468bc1
Change to startswith
agroce Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions slither/detectors/naming_convention/naming_convention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class NamingConvention(AbstractDetector):
Exceptions:
- Allow constant variables name/symbol/decimals to be lowercase (ERC20)
- Allow '_' at the beggining of the mixed_case match for private variables and unused parameters
- Ignore echidna properties (functions with names starting 'echidna_' or 'crytic_'
"""

ARGUMENT = 'naming-convention'
Expand Down Expand Up @@ -97,6 +98,8 @@ def _detect(self):
if not self.is_mixed_case(func.name):
if func.visibility in ['internal', 'private'] and self.is_mixed_case_with_underscore(func.name):
continue
if func.name.startswith("echidna_") or func.name.startswith("crytic_"):
continue
info = "Function '{}' ({}) is not in mixedCase\n"
info = info.format(func.canonical_name, func.source_mapping_str)

Expand Down